On April 13, 2019 17:48, SZEDER Gábor wrote: > On Sat, Apr 13, 2019 at 10:39:35PM +0200, Ævar Arnfjörð Bjarmason wrote: > > On Sat, Apr 13 2019, Randall S. Becker wrote: > > > > > I am encountering a problem on one of our NonStop platform variants > > > where the GIT_SSH_COMMAND string is not being broken into > > > constituent parts. This is causing SSH to not run properly. As > > > background, SSH is not in a standard location and has non-standard > > > required arguments. This also occurs with core.sshCommand. The > situation is: > > > > > > git config --global core.sshCommand '/G/system/zssh/sshossz5 -Q' > > > > > > which correctly sets .gitconfig as: > > > > > > [core] > > > sshCommand = /G/system/zssh/sshossz5 -Q > > > > > > When git is run with GIT_TRACE=true GIT_PACKET_TRACE=true git fetch > > > > > > We get the partial trace: > > > 14:19:56.027088 trace: built-in: git fetch > > > 14:19:56.029895 trace: run_command: '/G/system/zssh/sshossz5 -Q' -G > > > user@host > > > > > > The same trace on our systems that actually do work results in: > > > 14:19:56.029895 trace: run_command: '/G/system/zssh/sshossz5' '-Q' > > > -G user@host > > > > > > I need help resolving why this is happening (as in where to look and > > > debug the situation). > > > > This doesn't seem to be documented *explicitly* (except between the > > lines & inferred), but it's only supported to pass a *command* there, > > i.e. the path of the ssh binary. > > 'man git' it quite explicit about this: > > $GIT_SSH_COMMAND takes precedence over $GIT_SSH, and is interpreted > by the shell, which allows additional arguments to be included. > $GIT_SSH on the other hand must be just the path to a program (which > can be a wrapper shell script, if additional arguments are needed). > > Quick test shows that the implementation agrees with the > documentation: > > $ GIT_TRACE=2 GIT_SSH_COMMAND='/usr/bin/ssh -v' git push -n github > 23:39:02.048870 git.c:419 trace: built-in: git push -n github > 23:39:02.060821 run-command.c:643 trace: run_command: unset > GIT_PREFIX; '/usr/bin/ssh -v' git@xxxxxxxxxx 'git-receive-pack > '\''/szeder/git'\''' > OpenSSH_7.2p2 Ubuntu-4ubuntu2.8, OpenSSL 1.0.2g 1 Mar 2016 > debug1: Reading configuration data /home/szeder/.ssh/config > <... snipt rest of the verbose ssh output ...> > > And the config setting works, too: > > $ GIT_TRACE=2 git -c core.sshCommand='/usr/bin/ssh -v' push -n github > 23:42:55.277776 git.c:439 trace: built-in: git push -n github > 23:42:55.285149 run-command.c:663 trace: run_command: unset > GIT_CONFIG_PARAMETERS GIT_PREFIX; '/usr/bin/ssh -v' git@xxxxxxxxxx > 'git-receive-pack '\''/szeder/git'\''' > OpenSSH_7.2p2 Ubuntu-4ubuntu2.8, OpenSSL 1.0.2g 1 Mar 2016 > debug1: Reading configuration data /home/szeder/.ssh/config > <...> > > Note that in both cases the trace shows '/usr/bin/ssh -v', IOW neither > $GIT_SSH_COMMAND nor 'core.sshCommand' are broken up. > > But this is just an avarage Linux box, so perhaps this is a NonStop-specific > issue? > > > > See the code around get_ssh_command() > > in connect.c. The whole env/config value we look up gets passed as one. > > > > So if you need arguments you need to create a wrapper script and set > > ssh command to that script. What is strange is that GIT_SSH_COMMAND='/usr/bin/ssh -v' should not execute if we are just looking at an object path. It should be broken into '/usr/bin/ssh' and '-v' otherwise spawn* or exec* will not execute it. I'm still trying to understand why I can successfully do things like the following: $ GIT_SSH_COMMAND="ssh -i ~/.ssh/myid" git fetch on virtually any platform at my disposal (Windows, Ubuntu, MacOS, the older NonStop variant), and have that work with no problem. Somewhere after get_ssh_command(), the command is being interpreted it its parts either as a shell or something else (still trying to find that).
