On 04/15, Denton Liu wrote: [...] > -extern int write_archive_entries(struct archiver_args *args, write_archive_entry_fn_t write_entry); > -extern void *object_file_to_archive(const struct archiver_args *args, > +int write_archive_entries(struct archiver_args *args, write_archive_entry_fn_t write_entry); > +void *object_file_to_archive(const struct archiver_args *args, > const char *path, const struct object_id *oid, > unsigned int mode, enum object_type *type, > unsigned long *sizep); Just skimming this patch, I notice that this now leaves a bunch of oddly indented parameter lists behind. We might want to re-indent those as well, as part of this patch or a follow up patch (so this patch can remain purely mechanical). Personally I dislike this inconsistent indentation more than the extern keyword, but not sure how others feel about it.
