On Wed, Apr 10, 2019 at 12:08:45AM +0900, Junio C Hamano wrote: > Jeff King <peff@xxxxxxxx> writes: > > > On Fri, Apr 05, 2019 at 08:19:30PM +0100, Ramsay Jones wrote: > > > >> > /* global flag to enable extra checks when accessing packed objects */ > >> > -extern int do_check_packed_object_crc; > >> > +int do_check_packed_object_crc; > >> > >> ... removing this 'extern' on an int variable sends 'sparse' > >> into a frenzy of warnings! :-D > >> > >> [You didn't use a global s/extern// by any chance?] > > > > Oh my. I did look at each one, but probably via replace-and-confirm in > > vim. I don't know how I managed to botch that one so badly. > > In any case, I think I have a correct SQUASH??? immediately on top > of this step queued. If there is nothing else needed, I think we > are ready to squash that in and merge the whole thing to 'next'. Yes, your squash looks good, and I don't think there were any other unaddressed comments. Thanks for fixing my bug. -Peff
