On 05/04/2019 19:03, Jeff King wrote: > As CodingGuidelines recommends, we do not need an "extern" when > declaring a public function. Let's drop these. Note that we leave the > extern on report_garbage(), as that is actually a function pointer, not > a function itself. Hmm, perhaps we need to edit CodingGuidelines to make it clear that the 'extern' keyword is not needed on _function_ declarations only. ;-) Because, ... [snip] > /* global flag to enable extra checks when accessing packed objects */ > -extern int do_check_packed_object_crc; > +int do_check_packed_object_crc; ... removing this 'extern' on an int variable sends 'sparse' into a frenzy of warnings! :-D [You didn't use a global s/extern// by any chance?] ATB, Ramsay Jones
