On Fri, Mar 29, 2019 at 4:35 PM Rohit Ashiwal <rohit.ashiwal265@xxxxxxxxx> wrote: > > Hi Elijah > > On Sat, Mar 30, 2019 at 4:56 AM Elijah Newren <newren@xxxxxxxxx> wrote: > > > > Overall this looks pretty good to me, just one question... > > > > :) > > > > 5. `[Bonus]` --signoff > > > > --signoff is new and surprises me. What's the plan with that one? > > > > I was reading the documentation of git-rebase[1], where I found that > `--signoff` flag is not available for interactive backend, i.e., it is not > possible to convert a commit into `Signed-off-by` commit while interactive > rebasing. I'm curious if you're looking at an old version of the documentation (...or maybe the documentation just isn't that clear?). Interactive rebases have supported --signoff since commit a852ec7f273c ("rebase: extend --signoff support", 2018-03-20)