Hi Elijah On Sat, Mar 30, 2019 at 4:56 AM Elijah Newren <newren@xxxxxxxxx> wrote: > > Overall this looks pretty good to me, just one question... > :) > > 5. `[Bonus]` --signoff > > --signoff is new and surprises me. What's the plan with that one? > I was reading the documentation of git-rebase[1], where I found that `--signoff` flag is not available for interactive backend, i.e., it is not possible to convert a commit into `Signed-off-by` commit while interactive rebasing. I though it might be a nice bonus to add, hence I listed it in "the plan". Thanks Rohit [1]: https://git-scm.com/docs/git-rebase#Documentation/git-rebase.txt---signoff
