It seems the list software dislikes Michael Haggerty for some reason, but as seen in my reply to his message my v4 has some unaddressed issues in the previous 8/8 that I need to get to: https://public-inbox.org/git/87pnqkco8v.fsf@xxxxxxxxxxxxxxxxxxx/ I'll have limited time next week to get to that, so in the meantime here's a re-send without that patch, but just the unrelated cleanup/tests & gc "expire" fix up to v3's 7/8. The only other change is fixing commit message nonsense (from an earlier version), which Peff pointed out. I'll then get to the issue mhaggerty noted & submit that independently later, but this should be ready for queuing & moving down to next, since (unlike the previous 8/8) none of it's tricky code we need to be really careful with. Ævar Arnfjörð Bjarmason (7): gc: remove redundant check for gc_auto_threshold gc: convert to using the_hash_algo gc: refactor a "call me once" pattern reflog tests: make use of "test_config" idiom reflog tests: test for the "points nowhere" warning reflog tests: assert lack of early exit with expiry="never" gc: handle & check gc.reflogExpire config builtin/gc.c | 37 +++++++++++++++++++++++++++++-------- t/t1410-reflog.sh | 25 +++++++++++++++++-------- t/t6500-gc.sh | 19 +++++++++++++++++++ 3 files changed, 65 insertions(+), 16 deletions(-) Range-diff: 1: 81694c8213 = 1: be889156db gc: remove redundant check for gc_auto_threshold 2: 4bdcf1d0be = 2: 764c9a7380 gc: convert to using the_hash_algo 3: 9444a1233a = 3: d521c22103 gc: refactor a "call me once" pattern 4: 60a06ae618 = 4: 768aba9889 reflog tests: make use of "test_config" idiom 5: 52838fdc44 = 5: 2ddbee93a1 reflog tests: test for the "points nowhere" warning 6: 6063429f10 ! 6: 97e3d74371 reflog tests: assert lack of early exit with expiry="never" @@ -3,8 +3,7 @@ reflog tests: assert lack of early exit with expiry="never" When gc.reflogExpire and gc.reflogExpireUnreachable are set to "never" - and --stale-fix isn't in effect (covered by the first part of the "if" - statement being modified here) we *could* exit early without + and --stale-fix isn't in effect we *could* exit early without pointlessly looping over all the reflogs. However, as an earlier change to add a test for the "points nowhere" 7: 6693d1d84d = 7: 48e5c234ae gc: handle & check gc.reflogExpire config 8: e0814569ab < -: ---------- reflog expire: don't assert the OID when locking refs -- 2.21.0.392.gf8f6787159e
