Hi Denton, On Mon, 25 Mar 2019, Denton Liu wrote: > On Mon, Mar 25, 2019 at 07:50:38PM +0100, Johannes Schindelin wrote: > > > P.S.: Did you run the test suite before submitting your patches? > > Usually I'm more diligent about running tests but I wrote this patchset > in the back of a car when I was running low on batteries. I only ran the > rebase-related tests but I guess that wasn't enough. I totally understand that kind of scenario. > My mistake, though. I'll be sure to _always_ run tests in the future. Please do not feel bad. I did work pretty hard on making the Azure Pipelines support as fast as it is for the very purpose of helping exactly situations like yours: to hand off the testing to the cloud when batteries run low (or when you want to use your laptop for something else than running Git's test suite). And of course to verify that you don't break things on platforms other than the one you happen to develop on. And to check the documentation. And to run some static analyses. :-) Maybe you want to open PRs at https://github.com/git/git or at https://github.com/gitgitgadget/git to benefit from that kind of automatic testing, benefitting from my work (which would make me feel real good about spending that amount of time on it). Ciao, Johannes
