Hi Johannes, On Mon, Mar 25, 2019 at 07:50:38PM +0100, Johannes Schindelin wrote: > Hi Denton, > > On Sat, 23 Mar 2019, Denton Liu wrote: > > > [...] > > > > This allows us to rewrite the above as > > > > git rebase -i --keep-base master > > > > and > > > > git rebase -x ./test.sh --keep-base master > > > > respectively. > > Just a quick note: this breaks t5407 because that test uses `git rebase > --keep` and expects that abbreviated option to be expanded to > `--keep-empty`, which is now no longer the only possible expansion. > > I just submitted a patch series to fix that, and other uses of abbreviated > options in the test suite, in > https://public-inbox.org/git/pull.167.git.gitgitgadget@xxxxxxxxx/T/#t Thanks for catching this. I replied with a (tiny) review. > > Ciao, > Johannes > > P.S.: Did you run the test suite before submitting your patches? Usually I'm more diligent about running tests but I wrote this patchset in the back of a car when I was running low on batteries. I only ran the rebase-related tests but I guess that wasn't enough. My mistake, though. I'll be sure to _always_ run tests in the future. Thanks, Denton
