On Mon, 2019-03-18 at 15:28 +0900, Junio C Hamano wrote: > Joe Perches <joe@xxxxxxxxxxx> writes: > > > My preference would be for correctness. > > I presume something like this isn't too onerous. > > I am guessing that /^---/ is to stop at the three-dash line *OR* > after the initial handful of lines of the first diff header (as the > last resort) and that is why it is not looking for /^---$/. Right. > If that is the case, I think it makes a lot of sense. It is a > general improvement not tied to the case that triggered this thread. > > Independently, I think it makes sense to do something like > > /^([a-z][a-z-]*-by|Cc): (.*)/i > > to tighten the match to exclude a non-trailer; that would have been > sufficient for the original case that triggered this thread.