On 16/03/2019 20.26, Baruch Siach wrote:
> Since commit ef0cc1df90f6b ("send-email: also pick up cc addresses from
> -by trailers") in git version 2.20, git send-email adds to cc list
> addresses from all *-by lines. As a side effect a line with
> '-Signed-off-by' is now also added to cc. This makes send-email pick
> lines from patches that remove patch files from the git repo. This is
> common in the Buildroot project that often removes (and adds) patch
> files that have 'Signed-off-by' in their patch description part.
Yocto/OpenEmbedded and other projects do the same
> Consider only *-by lines that start with [a-z] (case insensitive) to
> avoid unrelated addresses in cc.
While I agree with Joe in principle that we really should not look
inside the diff part, all lines there start with [ +-], so we wouldn't
normally pick up anything from that due to the anchoring. Except for the
misc-by regexp that added hyphens to grab Reported-and-tested-by and
similar. So this is by far the simplest fix that doesn't hurt the common
use cases the misc-by handling was added to support, so
Acked-by: Rasmus Villemoes <rv@xxxxxxxxxxxxxxxxxx>
Rasmus
