On Sat, 2019-03-16 at 22:14 +0200, Baruch Siach wrote: > Hi Joe, Hello Baruch. > On Sat, Mar 16 2019, Joe Perches wrote: > > So buildroot uses '+Signed-off-by:' and '-Signed-off-by:' lines > > for some internal purpose? > > > > Why? > > > > https://buildroot.org/downloads/manual/manual.html > > > > doesn't mention it. > > No. Patches to the Buildroot project often add or remove patch > files. See this one for example: > > http://lists.busybox.net/pipermail/buildroot/2019-March/244762.html > > In this case 'git send-email' added Peter Korsgaard to cc because a > patch file with his sign-off is removed. > > (mbox) Adding cc: Baruch Siach <baruch@xxxxxxxxxx> from line 'From: Baruch Siach <baruch@xxxxxxxxxx>' > (body) Adding cc: Petr Vorel <petr.vorel@xxxxxxxxx> from line 'Cc: Petr Vorel <petr.vorel@xxxxxxxxx>' > (body) Adding cc: Baruch Siach <baruch@xxxxxxxxxx> from line 'Signed-off-by: Baruch Siach <baruch@xxxxxxxxxx>' > (body) Adding cc: Peter Korsgaard <peter@xxxxxxxxxxxxx> from line '-Signed-off-by: Peter Korsgaard <peter@xxxxxxxxxxxxx>' I see. IMO git send-email should not really be adding -by: lines from actual patch content but only from lines before any '^---'.
