Re: [PATCH v1 06/11] restore: add --worktree and --index

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Elijah Newren <newren@xxxxxxxxx> writes:

>> +               /*
>> +                * NEEDSWORK: if --worktree is not specified, we
>> +                * should save stat info of checked out files in the
>> +                * index to avoid the next (potentially costly)
>> +                * refresh. But it's a bit tricker to do...
>> +                */
>> +               rollback_lock_file(&lock_file);
>
> A total tangent: I see both FIXME and NEEDSWORK in the codebase.
> Are there other 'keywords' of this type that we use?  Is there a
> preference for how they are used?

If it makes it simpler, I can easily declare that NEEDSWORK is the
preferred one (I do not think I ever wrote anything else) to avoid
wasting list bandwidth ;-)




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux