On Sun, Mar 10, 2019 at 1:52 AM Elijah Newren <newren@xxxxxxxxx> wrote: > > + /* > > + * NEEDSWORK: if --worktree is not specified, we > > + * should save stat info of checked out files in the > > + * index to avoid the next (potentially costly) > > + * refresh. But it's a bit tricker to do... > > + */ > > + rollback_lock_file(&lock_file); > > A total tangent: I see both FIXME and NEEDSWORK in the codebase. Are > there other 'keywords' of this type that we use? Is there a > preference for how they are used? I don't think so. I've seen FIXME, NEEDSWORK, TODO and XXX. I think it's often up to the author to pick one. We could unify and use just one keyword, which helps spot these. But I don't think we keep future other keywords out long term. This seems to pick up most of them with a couple false positives git grep '^\s*\* [A-Z]\+: ' \*.c -- Duy
