On Tue, Mar 12, 2019 at 10:17:56PM +0100, Ævar Arnfjörð Bjarmason wrote: > > Here's a commit which updates Git to use the new feature. I've tested it > > with both the in-tree and submodule builds like: > > > > make DC_SHA1_SUBMODULE=Yes SANITIZE=undefined && (cd t && ./t0001-*) > > make DC_SHA1_SUBMODULE= SANITIZE=undefined && (cd t && ./t0001-*) > > > > both of which fail without this patch and succeed without it. > > FWIW I've reproduced this testing and found the same thing. Looks good > to me. Er, that second "without" should be "with", but hopefully you figured that out during your testing. :) -Peff