On Sat, Mar 9, 2019 at 7:34 AM Jeffrey Walton <noloader@xxxxxxxxx> wrote: > > On Fri, Mar 8, 2019 at 12:43 PM Todd Zullinger <tmz@xxxxxxxxx> wrote: > > > > Jeffrey Walton wrote: > > > Fedora 29, x86_64. One failed self test: > > > > > > *** t0021-conversion.sh *** > > [...] > > > not ok 13 - disable filter with empty override > > > # > > > # test_config_global filter.disable.smudge false && > > > # test_config_global filter.disable.clean false && > > > # test_config filter.disable.smudge false && > > > # test_config filter.disable.clean false && > > > # > > > # echo "*.disable filter=disable" >.gitattributes && > > > # > > > # echo test >test.disable && > > > # git -c filter.disable.clean= add test.disable 2>err && > > > # test_must_be_empty err && > > > # rm -f test.disable && > > > # git -c filter.disable.smudge= checkout -- test.disable 2>err && > > > # test_must_be_empty err > > > # > > [...] > > > # failed 1 among 26 test(s) > > > 1..26 > > > gmake[2]: *** [Makefile:56: t0021-conversion.sh] Error 1 > > > > > > Does anyone need a config.log or other test data? > > > > It would probably help to know what commit you're building. > > The verbose test output would also be useful, e.g.: > > I built with CFLAGS += -fsanitize=undefined. It looks like the > misaligned accesses generate UBsan findings, which is causing > t0021-conversion to fail. > > git-2.21.0$ grep -IR 'runtime error' > t/trash directory.t0021-conversion/err:sha1dc/sha1.c:392:2: runtime > error: load of misaligned address 0x0000024fc245 for type 'const > uint32_t', which requires 4 byte alignment > t/trash directory.t0021-conversion/err:sha1dc/sha1.c:397:2: runtime > error: load of misaligned address 0x0000024fc245 for type 'const > uint32_t', which requires 4 byte alignment > t/trash directory.t0021-conversion/err:sha1dc/sha1.c:402:2: runtime > error: load of misaligned address 0x0000024fc245 for type 'const > uint32_t', which requires 4 byte alignment I think this is the patch for sha1dc/sha1.c . It stops using unaligned accesses by default, but still honors SHA1DC_FORCE_UNALIGNED_ACCESS for those who want it. Folks who want the undefined behavior have to do something special. Jeff
Attachment:
git.patch
Description: Binary data
