Daniel Barkalow schrieb: > On Sun, 8 Jul 2007, Junio C Hamano wrote: > >> Are _identifiers with leading underscore Kosher thing to do, I >> wonder... We do have ones with trailing ones (mostly qsort >> functions) and I think they are done that way for the sake of >> standards conformance. > > I'm not sure; I inherited that bit of code from Julian. Do we have a > standard idiom for a function that sets a bunch of static variables? You could put all flags and settings into a struct fetch_pack_args. You could then go one step further by exporting the struct definition and letting the internal interface take a pointer to such a struct, thereby getting rid of static variables and their setup routine. René - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
