Are _identifiers with leading underscore Kosher thing to do, I wonder... We do have ones with trailing ones (mostly qsort functions) and I think they are done that way for the sake of standards conformance. Gone is a "#if 0/#endif" which is good. diff --git a/fetch-pack.h b/fetch-pack.h new file mode 100644 index 0000000..2bd05a8 --- /dev/null +++ b/fetch-pack.h @@ -0,0 +1,16 @@ +#ifndef FETCH_PACK_API We seem to say "#ifndef FETCH_PACK_H" in such a case, though. Nobody seems to call setup_fetch_pack() yet. How complete is this patch meant to be? The program is somehow much more pleasant to follow, even though there is no fundamental change anywhere. - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
