Junio C Hamano wrote: > Brandon Casey <casey@xxxxxxxxxxxxxxx> writes: ... >> This still allows an empty GIT_AUTHOR_EMAIL or GIT_COMMITTER_EMAIL. >> Possibly someone would want to use these variables to disable >> the respective email address string? >> >> Signed-off-by: Brandon Casey <casey@xxxxxxxxxxxxxxx> > > Thanks. But this makes me wonder why you do not do the same > check for !*email I thought someone may want to disable the author or committer email address by setting GIT_AUTHOR_EMAIL or GIT_COMMITTER_EMAIL to an empty string. I wasn't sure this was useful that's why I put a '?' at the end of my commit message. >> Then I send the patch to myself using git-format-patch and then >> git-send-email. These two format the patch appropriately for >> submission and allow me to set the message-id. >> >> Then I select the message, right-click and choose "Edit As New...", >> edit, select the recipients, and send. I also now have a record of >> the sent message which I would not have if I used only git-send-email. > > I would just add myself to --bcc when running send-email; much > simpler ;-). currently I can only use send-email to send email to myself, so this was an alternative to setting up an external editor in thunderbird. It's currently the path of least resistance for me. -brandon - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html