Brandon Casey <casey@xxxxxxxxxxxxxxx> writes: Brandon Casey <casey@xxxxxxxxxxxxxxx> writes: > Attempt normal methods for determining user name if > GIT_AUTHOR_NAME or GIT_COMMITTER_NAME is set to the empty > string. Then fall back to using the user login name. > > Previously, if these environment variables were set to the > empty string, a message would be printed complaining about > missing gecos information. In this case the gecos information > was never checked. > > This still allows an empty GIT_AUTHOR_EMAIL or GIT_COMMITTER_EMAIL. > Possibly someone would want to use these variables to disable > the respective email address string? > > Signed-off-by: Brandon Casey <casey@xxxxxxxxxxxxxxx> Thanks. But this makes me wonder why you do not do the same check for !*email > Then I send the patch to myself using git-format-patch and then > git-send-email. These two format the patch appropriately for > submission and allow me to set the message-id. > > Then I select the message, right-click and choose "Edit As New...", > edit, select the recipients, and send. I also now have a record of > the sent message which I would not have if I used only git-send-email. I would just add myself to --bcc when running send-email; much simpler ;-). > ident.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/ident.c b/ident.c > index 3d49608..6932ccf 100644 > --- a/ident.c > +++ b/ident.c > @@ -193,7 +193,7 @@ const char *fmt_ident(const char *name, const char *email, > int i; > > setup_ident(); > - if (!name) > + if (!name || !*name) > name = git_default_name; > if (!email) > email = git_default_email; > -- > 1.5.3.rc0.30.g114f-dirty - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
