On Mon, Feb 11, 2019 at 2:09 AM Randall S. Becker <rsbecker@xxxxxxxxxxxxx> wrote: > > Hi All, > > I tracked down a breakage in t1404 subtest 52. The line > > test_i18ngrep "Unable to create $Q.*packed-refs.lock$Q: File exists" err The message does not match, does it? Here we grep for "File exists" but the message you showed says "File already exists". > is correctly working, but is reporting a completion 1. > > The verbose output, with diagnostics, is: > > error: 'grep Unable to create '.*packed-refs.lock': File exists err' didn't > find a match in: > error: Unable to create '/home/git/git/t/trash > directory.t1404-update-ref-errors/.git/packed-refs.lock': File already > exists. > > Another git process seems to be running in this repository, e.g. > an editor opened by 'git commit'. Please make sure all processes > are terminated then try again. If it still fails, a git process > may have crashed in this repository earlier: > remove the file manually to continue. > > Reported 1 from test_i18ngrep > > err contains (without the double quotes): > "error: Unable to create '/home/git/git/t/trash > directory.t1404-update-ref-errors/.git/packed-refs.lock': File already > exists. > > Another git process seems to be running in this repository, e.g. > an editor opened by 'git commit'. Please make sure all processes > are terminated then try again. If it still fails, a git process > may have crashed in this repository earlier: > remove the file manually to continue." > > Which means that > > ! test_have_prereq C_LOCALE_OUTPUT || test_cmp "$@" > > is completing with a 1. Is that the intent? Any clues? > > Thanks, > Randall > -- Duy
