On Tue, Jan 08, 2019 at 12:38:26PM -0800, Jonathan Tan wrote: > > Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> writes: > > > > > From: Jonathan Tan <jonathantanmy@xxxxxxxxxx> > > > > > > I was looking at the topics in 'pu' and noticed that I had v2 of > > this series, wanted to update to v3, but major part of it was > > superseded by another topic (jk/proto-v2-hidden-refs-fix). That > > leaves only this patch in the v3 of this series. > > > > Is this one still relevant? > > This patch is more relevant to the GIT_TEST_PROTOCOL_VERSION patches, > since it means that several tests work even if > GIT_TEST_PROTOCOL_VERSION=2 is set. I think it can be dropped until > someone restarts the GIT_TEST_PROTOCOL_VERSION effort, but I'm not sure > if Ævar has another opinion. I think it's independently useful. If you set protocol.version=2 in your config, then you can no longer run fetch-pack directly. Most people don't, but it's possible their scripts might (we also use fetch-pack under the hood for smart-http, but I wasn't able to get it to complain, though). -Peff
