Duy Nguyen <pclouds@xxxxxxxxx> writes: > On Thu, Dec 13, 2018 at 7:08 PM Duy Nguyen <pclouds@xxxxxxxxx> wrote: >> There's also a bug in my patch (-2 is already being used by >> parse_opt_unknown_cb and my patch will change behavior of git-blame at >> least in theory). > > Ah no. Too many magic numbers in parse-options.c code. It's working > fine but I'll need to give these some names to avoid confusion in the > future. OK.