On Thu, Dec 13, 2018 at 3:05 PM Ævar Arnfjörð Bjarmason
<avarab@xxxxxxxxx> wrote:
>
>
> On Thu, Dec 13 2018, Junio C Hamano wrote:
>
> > Here is an excerpt from a draft edition of "What's cooking" report
> > for topics that are about an immediate 2.20.1 maintenance release,
> > with five topics that I plan to merge to 'next' and then to 'maint'
> > soonish (they're all marked as "Will merge to 'next' and then to
> > 'master'").
> >
> > They'll be in 'pu' but not in 'next' in today's pushout, but unless
> > I hear breakage reports in time, I am hoping to merge them to 'next'
> > during tomorrow's integration cycle, so that we can start the new
> > week with 2.20.1.
> > [...]
> > * nd/show-gitcomp-compilation-fix (2018-12-12) 1 commit
> > - parse-options: fix SunCC compiler warning
> >
> > Portability fix for a recent update to parse-options API.
>
> Since I reported this, just a clarification: Unlike 46c0eb5843
> ("files-backend.c: fix build error on Solaris", 2018-11-25) this one's
> not an error on suncc, just a warning (and we have 20-30 of those exact
> warnings in our code).
>
> So if you wanted to minimize 2.20.1 this could be held back, but also it
> looks obviously correct so it's fine that it makes it into that point
> release. Just FYI.
There's also a bug in my patch (-2 is already being used by
parse_opt_unknown_cb and my patch will change behavior of git-blame at
least in theory). I'll reroll later. I think it's better to hold it
back.
--
Duy
