On Thu, Nov 1, 2018 at 3:04 PM Junio C Hamano <gitster@xxxxxxxxx> wrote: > > Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> writes: > > > Could you please pick up > > https://public-inbox.org/git/20181024114725.3927-1-avarab@xxxxxxxxx/ ? > > It seems to have fallen between the cracks and addressed the feedback on > > v1, and looks good to me (and nobody's objected so far...). > > If this is the runtime-gettext-poison thing, this did not fall thru > the cracks---I didn't get the impression that "no objection was a > sign of being excellent"; rather I recall feeling that you were the > only person who were excited about it, while everybody else was > "Meh". I would be more excited if the scrambling patches go first (*) and then we start to make "make test" poisoned by default. Scrambled output is still very readable and it will make people not forget about grepping translated stuff the wrong way. Of course *i18n* functions in the test suite need to be updated to to grep/compare for real, not just exit early like they do now. (*) The pseudolocalization idea is also good, but printing unicode by default may be a bit of a stretch. Not everybody is running the test suite with a unicode-capable terminal. -- Duy
