On Thu, Nov 01, 2018 at 12:02:01PM +0100, Ævar Arnfjörð Bjarmason wrote: > Could you please pick up > https://public-inbox.org/git/20181024114725.3927-1-avarab@xxxxxxxxx/ ? > It seems to have fallen between the cracks and addressed the feedback on > v1, and looks good to me (and nobody's objected so far...). I didn't object, because in https://public-inbox.org/git/87muqzllh0.fsf@xxxxxxxxxxxxxxxxxxx/ you asked for "a more general review than just the problem of how we turn an env variable into a boolean". However, if you push that patch with 'sh-i18n--helper' as-is, then I do object now: parsing a boolean in shell is not at all that difficult to justify this new command.
