On Thu, Oct 11, 2018 at 05:25:02PM +0900, Junio C Hamano wrote: > Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> writes: > > > On Wed, Oct 10 2018, Lucas De Marchi wrote: > > > >> Do like it's done in grep so mode doesn't end up as > >> 0160000, which means range-diff doesn't work if one has > >> "submodule.diff = log" in the configuration. Without this > >> while using range-diff I only get a > >> > >> Submodule a 0000000...0000000 (new submodule) > > > > I'm not familiar enough with this to tell what the real problem is > > that's being solved from the commit message, but if it means that now > > range-diff works in some configuration, presumably that can be reduced > > to a simple set of commands that didn't work before but now does, and > > therefore a test in t/t3206-range-diff.sh. > > Yes, I agree on both counts (i.e. it was totally unclear what > problem is being solved and what the root cause of the problem is, > and we would want a new test to protect this "fix" from getting > broken in the future. have you seen I sent a v2 with proper test? thanks Lucas De Marchi > > Thanks.
