Re: [PATCH 1/2] Add test script for git-stripspace.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2007/6/27, Junio C Hamano <gitster@xxxxxxxxx>:
Thanks.  That's extensive set of tests for a little utility.

I hope not being overtesting the program. In order to reuse the
function that does this job from the builtins, perhaps we need another
implementation doing the same in a memory buffer instead a file
stream. The tests save the need to feed manually the program in this
development, and clarify the expected behaviour for the utility.

> new file mode 100644
100755?

> +    cat expect | git-stripspace >actual &&
Please don't cat a single file into a pipeline.
        git-stripspace <actual >expect

Thank you for your corrections. I Will resend it with those fixed.
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux