On Wed, Oct 03, 2018 at 12:16:58PM +0200, SZEDER Gábor wrote: > On Tue, Oct 02, 2018 at 03:55:19PM -0400, Jeff King wrote: > > On Tue, Oct 02, 2018 at 12:16:42PM -0700, Jacob Keller wrote: > > > > > make coccicheck is used in order to apply coccinelle semantic patches, > > > and see if any of the transformations found within contrib/coccinelle/ > > > can be applied to the current code base. > > > > > > Pass every file to a single invocation of spatch, instead of running > > > spatch once per source file. > > > > > > This reduces the time required to run make coccicheck by a significant > > > amount of time: > > > > > > Prior timing of make coccicheck > > > real 6m14.090s > > > user 25m2.606s > > > sys 1m22.919s > > > > > > New timing of make coccicheck > > > real 1m36.580s > > > user 7m55.933s > > > sys 0m18.219s > > > > Yay! This is a nice result. > > > > It's also one of the things that Julia suggested in an earlier thread. > > One thing I wasn't quite sure about after digging into the various > > versions (1.0.4 on Debian stable/unstable, 1.0.6 in experimental, and > > pre-1.0.7 at the bleeding edge) was whether the old versions would be > > similarly helped (or work at all). > > > > I just replicated your results with 1.0.4.deb-3+b2 from Debian stable. > > It's possible there are older versions floating around, but for > > something developer-only like this, I think "in Debian stable" is a > > reasonable enough cutoff. > > Linux build jobs on Travis CI run Ubuntu Trusty 14.04 LTS, and > therefore our static analysis build job still runs 1.0.0~rc19.deb-3. > > This patch appears to work fine with that version, too, In fact, it works finer than ever, because running 1.0.0 with this patch on Travis CI notices a possible memmove() -> MOVE_ARRAY() conversion: https://travis-ci.org/szeder/git/jobs/436542684#L576 Surprisingly, running 1.0.0 without this patch, or running 1.0.4 locally either with or without this patch doesn't notice that memmove() call. Presumably that's why Jonathan could kind-of "revert" my conversion from f919ffebed (Use MOVE_ARRAY, 2018-01-22) in his 6a1a79fd14 (object: move grafts to object parser, 2018-05-15) without anyone noticing.
