Jim Meyering <jim@xxxxxxxxxxxx> writes: > From: Jim Meyering <jim@xxxxxxxxxxxx> > Date: Sat, 26 May 2007 13:43:07 +0200 > Subject: [PATCH] Don't ignore write failure from git-diff, git-log, etc. > > Currently, when git-diff writes to a full device or gets an I/O error, > it fails to detect the write error: > ... > Also, to be consistent with e.g., write_or_die, do not > diagnose EPIPE write failures. I still do not like the fact that this patch makes an error from the final stdout flushing override the return value from p->fn() even when the function already diagnosed an error, but otherwise I think it is a good change, as it allows us to catch one error case that we currently don't, without introducing an annoying EPIPE diagnosis. Naks, or vetoes? - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html