Hi Jun, Here's a copy of my patch, from here: http://thread.gmane.org/gmane.comp.version-control.git/48469/focus=48636 Jim ----------------------------- >From 42e3a6f676e9ae4e9640bc2ff36b7ab0b061a60e Mon Sep 17 00:00:00 2001 From: Jim Meyering <jim@xxxxxxxxxxxx> Date: Sat, 26 May 2007 13:43:07 +0200 Subject: [PATCH] Don't ignore write failure from git-diff, git-log, etc. Currently, when git-diff writes to a full device or gets an I/O error, it fails to detect the write error: $ git-diff |wc -c 3984 $ git-diff > /dev/full && echo ignored write failure ignored write failure git-log does the same thing: $ git-log -n1 > /dev/full && echo ignored write failure ignored write failure Each and every git command should report such a failure. Some already do, but with the patch below, they all do, and we won't have to rely on code in each command's implementation to perform the right incantation. $ ./git-log -n1 > /dev/full fatal: write failure on standard output: No space left on device [Exit 128] $ ./git-diff > /dev/full fatal: write failure on standard output: No space left on device [Exit 128] You can demonstrate this with git's own --version output, too: (but git --help detects the failure without this patch) $ ./git --version > /dev/full fatal: write failure on standard output: No space left on device [Exit 128] Note that the fcntl test (for whether the fileno may be closed) is required in order to avoid EBADF upon closing an already-closed stdout, as would happen for each git command that already closes stdout; I think update-index was the one I noticed in the failure of t5400, before I added that test. Also, to be consistent with e.g., write_or_die, do not diagnose EPIPE write failures. Signed-off-by: Jim Meyering <jim@xxxxxxxxxxxx> --- git.c | 19 ++++++++++++++++++- 1 files changed, 18 insertions(+), 1 deletions(-) diff --git a/git.c b/git.c index 29b55a1..8258885 100644 --- a/git.c +++ b/git.c @@ -308,6 +308,7 @@ static void handle_internal_command(int argc, const char **argv, char **envp) for (i = 0; i < ARRAY_SIZE(commands); i++) { struct cmd_struct *p = commands+i; const char *prefix; + int status; if (strcmp(p->cmd, cmd)) continue; @@ -321,7 +322,23 @@ static void handle_internal_command(int argc, const char **argv, char **envp) die("%s must be run in a work tree", cmd); trace_argv_printf(argv, argc, "trace: built-in: git"); - exit(p->fn(argc, argv, prefix)); + status = p->fn(argc, argv, prefix); + + /* Close stdout if necessary, and diagnose any failure + other than EPIPE. */ + if (fcntl(fileno (stdout), F_GETFD) >= 0) { + errno = 0; + if ((ferror(stdout) || fclose(stdout)) + && errno != EPIPE) { + if (errno == 0) + die("write failure on standard output"); + else + die("write failure on standard output" + ": %s", strerror(errno)); + } + } + + exit(status); } } -- 1.5.2.73.g18bece - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
