Junio C Hamano <gitster@xxxxxxxxx> writes: > "Derrick Stolee via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes: > >> contrib/coverage-diff.sh | 70 ++++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 70 insertions(+) >> create mode 100755 contrib/coverage-diff.sh > > I fully appreciate the motivation. But it is a bit sad that this > begins with "#!/bin/bash" but it seems that the script is full of > bash-isms. I haven't gone through the script to see if these are > inevitable or gratuitous yet, but I'd assume it made it easier for > you to write it to step outside the pure POSIX shell? > ... >> + elif [[ $REPLY =~ \+\+\+\ (b/)?([^[:blank:]$esc]+).* ]]; then >> + path=${BASH_REMATCH[2]} > > OK, it probably is easier to write in bash than using expr if you > want to do regexp. Just to clarify. I am saying that it is OK to give up writing in pure POSIX and relying on bash-isms after seeing these lines.