Stefan Beller <sbeller@xxxxxxxxxx> writes: > On Sun, Sep 9, 2018 at 1:54 AM Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> wrote: >> >> --- > > Junio would have to forge your Sign off here? > (I just realize this holds true for the whole series, > but it occurred to me in this patch, as I was looking at > the diff_setup[_done] part on the previous round. That is fine; as I said elsewhere, I am treating patches, other than regression fixes, sent to the list during prerelease freeze as mere "test data" for the 2.19-pre version of Git, and I may end up keeping the result of testing "git am" on them as topic branches, but there is no promise I'd do so. Reading patches on the list and commenting on them can be done without sign-offs; you can treat them as an early draft that is not meant for the final application. I may come back to leftover patches in the list archive after the release is made, but honestly I'd prefer to see them sent afresh after the final for the next round, taking input from the review comments as necessary.