On Sat, Jun 23, 2007 at 03:14:08AM -0700, Junio C Hamano wrote: > Well, "Encode::FB_CLUCK" is a bogus symbol even in recent Perl. > IOW, the tested function does not seem to care if I give > whatever garbage as the second parameter. > > But I guess you are only interested if the perl used to run > gitweb barfs with that two parameter, so the original check > would be the right way. Indeed. gitweb doesn't use FB_CLUCK and if it did, we would want to know about it (and not skip the tests). skimo - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html