Sven Verdoolaege <skimo@xxxxxxxxxx> writes:
> On Fri, Jun 22, 2007 at 11:31:40PM -0700, Junio C Hamano wrote:
>> Sven Verdoolaege <skimo@xxxxxxxxxx> writes:
>> > +perl -MEncode -e 'decode_utf8("", Encode::FB_CROAK)' >/dev/null 2>&1 || {
>> > + test_expect_success 'skipping gitweb tests, perl version is too old' :
>> > + test_done
>> > + exit
>> > +}
>> > +
>>
>> Hmph. Even something silly like:
>>
>> perl -MEncode -e 'decode_utf8("", Encode::FB_CLUCK)'
>>
>> seem to succeed for me with 5.8.8.
>>
>
> Maybe I'm missing something, but it's supposed to succeed
> for perl versions that are recent enough.
Well, "Encode::FB_CLUCK" is a bogus symbol even in recent Perl.
IOW, the tested function does not seem to care if I give
whatever garbage as the second parameter.
But I guess you are only interested if the perl used to run
gitweb barfs with that two parameter, so the original check
would be the right way.
Will apply, but I am about to go to bed, so it will be
tomorrow.
Thanks.
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
