On Tue, Aug 21, 2018 at 01:52:33PM -0700, Junio C Hamano wrote: > > I think there really are two bugs here, though. The find_patch_start() > > check is overly lax, but we also should not have to use it at all when > > we know there is no patch. > > Yes, I was grepping for callchains, and it appeared none of them > actually expected us to feed "log plus --- plus patch" format. The > obvious candidate to take it is "am" but we ask mailinfo to do the > splitting before the log message part even hits the rest of the > system. So my inclination right now is to see if that is truly the > case and get rid of that bogus "patch start" thing, and if not, add > a flag to let the caller say "I know we only have message" to the > callchain. I suspect this same logic is used by git-interpret-trailers, which is taking an arbitrary message on stdin. That is probably the lone caller that needs to retain this magic. -Peff
