Jeff King <peff@xxxxxxxx> writes: > Another is to tighten the check. Something like this seems more > sensible: Great minds think alike; is it a space was exactly what I was toying with before I went to lunch. FWIW I saw the full test suite passes when I came back and then saw you had an identical patch ;-) > I think there really are two bugs here, though. The find_patch_start() > check is overly lax, but we also should not have to use it at all when > we know there is no patch. Yes, I was grepping for callchains, and it appeared none of them actually expected us to feed "log plus --- plus patch" format. The obvious candidate to take it is "am" but we ask mailinfo to do the splitting before the log message part even hits the rest of the system. So my inclination right now is to see if that is truly the case and get rid of that bogus "patch start" thing, and if not, add a flag to let the caller say "I know we only have message" to the callchain.
