Elijah Newren wrote: > Signed-off-by: Elijah Newren <newren@xxxxxxxxx> > --- > compat/precompose_utf8.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Jonathan Nieder <jrnieder@xxxxxxxxx> The more unusual style is less likely to be recognized by compilers, so we can waste some I/O re-reading the header at compile time. > --- a/compat/precompose_utf8.h > +++ b/compat/precompose_utf8.h > @@ -1,4 +1,6 @@ > #ifndef PRECOMPOSE_UNICODE_H > +#define PRECOMPOSE_UNICODE_H > + > #include <sys/stat.h> > #include <sys/types.h> > #include <dirent.h> Not about this patch: these headers are #include-d in git-compat-util.h which we assume to be already included first before anything else. Can we remove these redundant #includes?