Elijah Newren wrote: > Signed-off-by: Elijah Newren <newren@xxxxxxxxx> > --- > urlmatch.h | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Jonathan Nieder <jrnieder@xxxxxxxxx> This has two benefits: - avoids the definitions in this header from being evaluated twice - many compilers recognize the #include guard idiom and also are able to avoid re-reading the text of the header twice, too The header guard had been broken since day one. Is there a tool that can detect this class of problem?