On Sat, Aug 4, 2018 at 11:33 PM Eric Sunshine <sunshine@xxxxxxxxxxxxxx> wrote: > On Sat, Aug 4, 2018 at 11:17 PM Jonathan Nieder <jrnieder@xxxxxxxxx> wrote: > > So it looks like FreeBSD has modernized and we need to make that > > conditional in config.mak.uname on $(uname_R). Do you know which > > version of FreeBSD changed the signature? Care to write a patch? > > I'm not very familiar with FreeBSD-land, but I would > hope there would be an easier way to determine when it changed than by > installing old versions. Does FreeBSD have historic package > repositories (containing headers, for instance) which one could > consult instead? I thought perhaps we could figure out the timeframe by looking at the Git package[1] in the FreeBSD ports tree to see when they added, removed, or changed a patch file for config.mak.uname, but that didn't pan out since they invoke the Git 'configure' script which determines OLD_ICONV automatically. [1]: https://github.com/freebsd/freebsd-ports/tree/master/devel/git