On Sat, Aug 4, 2018 at 8:11 AM Jonathan Nieder <jrnieder@xxxxxxxxx> wrote: > My main concern is not about them but about other > people building from source in order to run (instead of to develop) > Git, and by extension, the people they go to for help when it doesn't > work. I have lots of bitter experience of -Werror being a support > headache and leading to bad workarounds when someone upgrades their > compiler and the build starts failing due to a new warning it has > introduced. Even old compilers can also throw some silly, false positive warnings (which now turn into errors) because they are not as smart as new ones. -- Duy