On 7/20/2018 6:16 PM, Stefan Beller wrote:
* Use single rev-parse commands in test output, and pipe the OIDs through 'sort'
Why do we need to sort them? The order of the answers given by rev-parse
is the same as the input given and we did not need to sort it before, i.e.
the unit under test would not give sorted output but some deterministic(?)
order, which we can replicate as input to rev-parse.
Am I missing the obvious?
The output of the test program is not always deterministic (or at least,
the order is determined by the implementation, but not as part of the
method contract). For example: get_all_merge_bases can return the list
of merge bases in any order.
By sorting, we can ensure the output values (and their multiplicity)
match expected.
Thanks,
-Stolee
