Hi Derrick, > Sure! It's on my fork [1] > > [1] https://github.com/derrickstolee/git/tree/reach/refactor > Thanks! > >> * Use single rev-parse commands in test output, and pipe the OIDs through 'sort' Why do we need to sort them? The order of the answers given by rev-parse is the same as the input given and we did not need to sort it before, i.e. the unit under test would not give sorted output but some deterministic(?) order, which we can replicate as input to rev-parse. Am I missing the obvious? > >> * Check output of parse_commit() > >> > >> * Update flag documentation in object.h > >> > >> * Add tests for commit_contains() including both algorithms. > >> > >> * Reduce size of "mixed-mode" commit-graph to ensure we start commit walks > >> 'above' the graph and then walk into the commits with generation numbers. Overall I like the series as-is, and have found no further issues in a quick read. Thanks, Stefan
