Alban Gruin <alban.gruin@xxxxxxxxx> writes:
> This patch series rewrite the interactive rebase from shell to C.
>
> It is based on master (as of 2018-07-24).
With fewer number of bytes than "as of ....", you can express it in
a more useful way, even when you and others live in different
timezones and when the 'master' branch is updated more than once in
the 24-hour period.
I think you based it on b7bd9486 ("Third batch for 2.19 cycle",
2018-07-18), so you can say so
It is based on b7bd9486 ("Third batch for 2.19 cycle",
2018-07-18).
with a bit more bytes for the subject and be more informative.
When you rebase your series, please explain why you needed to do so
in your cover letter. "I just wanted to catch up with the latest
'master'" is not a good enough reason. "I wanted to make sure my
series works well with X and Y that the base of my previous attempt
did not have." is a very good reason.
I think the rebase this round is warranted, if it was done to take
advantage of the fix made by Elijah to the code that handles the
"strategy" option in 0060041d ("Fix use of strategy options with
interactive rebases", 2018-06-27), in other words, you wanted to
start from the version of read_strategy_opts() Elijah fixed when
you split parse_strategy_opts() out of it in step [15/20].
I'll send comments on individual patches separately.
Thanks.
