On Tue, Jul 24, 2018 at 9:34 AM Alban Gruin <alban.gruin@xxxxxxxxx> wrote: > > This patch series rewrite the interactive rebase from shell to C. > > It is based on master (as of 2018-07-24). > > Changes since v3: > > - The `--verbose` option is stored directly into opts.verbose > > - Drop includes in rebase-interactive.h > > - skip_unnecessary_picks() now returns an object_id instead of a string > > - Add a test case to ensure interactive rebase aborts when the todo > list only has commented-out commands > > - complete_action() aborts when the todo list only has commented-out > commands > > - Drop the `keep_empty` parameter of complete_action() > > - Don’t remove the modes `--shorten-oids` and `--expand-oids` from > git-rebase--helper > > - Replace `ret = !!x(); return ret` by `ret = x(); return !!ret` > > - Fail if `--make-script` is provided with two arguments instead of > one > > - Rewrite write_basic_state() and init_basic_state() in C > > - Rewrite git-rebase--interactive.sh as a builtin > I gave that series a read and I think it looks good. Thanks, Stefan
