At least the older humongous pretty_print_commit() got separated into manageable chunks, and I was happy. I was just too lazy when refactoring the code and stopped there. The right fix is to propagate the "realloc as needed" callchain into add_user_info(), instead of having "this should be enough" there. These two you touched are the only two callsite of that static function. - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html