On Mon, Jul 16, 2018 at 6:00 AM Derrick Stolee via GitGitGadget <gitgitgadget@xxxxxxxxx> wrote: > + > +int commit_contains(struct ref_filter *filter, struct commit *commit, > + struct commit_list *list, struct contains_cache *cache) [...] > - > -static int commit_contains(struct ref_filter *filter, struct commit *commit, > - struct commit_list *list, struct contains_cache *cache) All moved code, but this one, which was exposed to the public. Might be worth calling out in the commit message? While exposing it, it is a good idea to question its name and if it is good enough for public use (I think it is -- despite not understanding what the function does by its arguments; so bonus points for docs!) Thanks, Stefan
