On Mon, Jul 16, 2018 at 6:00 AM Derrick Stolee via GitGitGadget <gitgitgadget@xxxxxxxxx> wrote: > > From: Derrick Stolee <dstolee@xxxxxxxxxxxxx> > > Signed-off-by: Derrick Stolee <dstolee@xxxxxxxxxxxxx> Another verbatim move! (I'll just re-iterate that the --color-moved option is very helpful in these reviews) Thanks, Stefan > +++ b/commit-reach.h > @@ -38,4 +38,6 @@ struct commit_list *reduce_heads(struct commit_list *heads); > */ > void reduce_heads_replace(struct commit_list **heads); > > +int ref_newer(const struct object_id *new_oid, const struct object_id *old_oid); > + Bonus points for docs on ref_newer! > +++ b/http-push.c > @@ -14,6 +14,7 @@ > #include "argv-array.h" > #include "packfile.h" > #include "object-store.h" > +#include "commit-reach.h" > > Double new line here? I missed that in p1, it would be nice if you could fix that up.
