On Thu, Jul 12, 2018 at 01:01:23PM -0700, William Chargin wrote: > Contents look good to me. I don't understand why the file name in your > patch is sha1_name.c as opposed to sha1-name.c (I see e5e5e0883 from > 2018-04-10, but that sounds pretty old), but I trust that whatever > you're doing there is correct. Junio typically applies bugfixes as close to the bug-source as possible, which allows them to be merged-up into various releases (rather than cherry-picked, which would be required if built on top of 'master'). Ideally this is directly on top of the commit that introduced the bug, though for an ancient bug like this, it's not worth the effort. It looks like he applied it on the 2.16 maint branch, which predates e5e5e0883. When it's merged up, the resolution will handle the rename (probably even automatically due to Git's rename detection). > > Thanks for working on this. > > You're quite welcome. Thanks to you, Peff, and Duy for your help. This > was a pleasant experience for me as a new contributor. :-) Great. Please come back anytime. :) -Peff
