On Thu, Jul 12, 2018 at 06:50:20AM -0400, Eric Sunshine wrote:
> And, perhaps most important: We're not tied indefinitely to the
> "subset" implemented by the current linter. If it is indeed found to
> be too strict or limiting, it can always be loosened or retired
> altogether.
Yeah, I agree this is the key point.
Like Junio, I'm a little nervous that this is going to end up being a
maintenance burden. People may hit false positives and then be
confronted with this horrible mass of sed to try to figure out what went
wrong (which isn't to bust on your sed in particular; I think you made a
heroic effort in commenting).
But I came around to thinking:
- this found and fixed real problems in the test suite, with minimal
false positives across the existing code
- it's being done by a long-time contributor, not somebody who is
going to dump sed on us and leave
- worst case is that relief is only a "git revert" away
So I'm OK with merging it, and even running it by default.
-Peff
